Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test of #34014 #34070

Merged
merged 1 commit into from
May 22, 2021
Merged

Fix test of #34014 #34070

merged 1 commit into from
May 22, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented May 21, 2021

Put the test in the right place. Replace the body removal, that destroys jasmine things, with a known safe wrapper

@GeoSot GeoSot added js p1 Critical, and inhibits core functionality v5 labels May 21, 2021
@GeoSot GeoSot marked this pull request as ready for review May 21, 2021 23:41
@GeoSot GeoSot requested a review from a team as a code owner May 21, 2021 23:41
@GeoSot GeoSot requested a review from alpadev May 22, 2021 00:15
@alpadev alpadev merged commit e06e6df into main May 22, 2021
@alpadev alpadev deleted the gs-regression-test-on-backdrop branch May 22, 2021 00:54
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request Aug 18, 2021
Fixes regression of twbs@a2b5901 breaking the test runner because it would wipe document.body.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
js p1 Critical, and inhibits core functionality v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants