Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in JavaScript doc example #34263

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Fix error in JavaScript doc example #34263

merged 1 commit into from
Jun 15, 2021

Conversation

mattdufresne
Copy link
Contributor

Remove the # symbol from the "Asynchronous functions and transitions" JavaScript example since it's uncommon to use # symbols in id attributes.

@GeoSot
Copy link
Member

GeoSot commented Jun 15, 2021

Thanks a lot @mattdufresne 😃

@mdo mdo merged commit 9485172 into twbs:main Jun 15, 2021
@mattdufresne mattdufresne deleted the fix-js-example branch June 15, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoSot GeoSot GeoSot approved these changes

Assignees
No one assigned
Labels
docs v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattdufresne @GeoSot @mdo @mattdufresne2