Remove explicit use of aria-hidden for offcanvas when closed

[patrickhlauke]

due to the .offcanvas styles already containing visibility:hidden, no need to add aria-hidden nor to explicitly set the style="" attribute when the offcanvas gets closed

Closes #35577

[XhmikosR]

Can you remove the dist files please?

[ffoodd]

Looks like you commited dist files. We can take care of it if needed 👌

Edit: Oh, just saw previous comment!

[patrickhlauke]

urgh, stupid dist files...

[ffoodd]

LGTM 👌

[GeoSot]

@patrickhlauke it will need something more (maybe one more class like .transitioning) in order to achieve better transition during close.

Ps: I can help if you like 😃

[patrickhlauke]

@patrickhlauke it will need something more (maybe one more class like .transitioning) in order to achieve better transition during close.

Aha, that explains it. I was wondering why all of a sudden this was setting/removing actual style attributes separately rather than just relying on classes. Clearly I'm a bit rusty (and hadn't fully checked the impact visually). Yeah if you don't mind giving an assist, that'd be awesome.

[patrickhlauke]

Let me set this to draft in the meantime so it doesn't get accidentally merged prematurely

[GeoSot]

Please check the functionality & changes, and if we agree on these, I will 'tweak' the test

Just to note down, that this approach (using more classes), would help in the near future streamlining most of the js components

[patrickhlauke]

@GeoSot just tested, seems to work really well. If you don't mind tweaking the tests, that'd be great

[GeoSot]

@ffoodd I would review it but I have also put my hands in here, so your review would help us 💯

[ffoodd]

I better aligned the CSS with our current code style. This is working fine so

[GeoSot]

I better aligned the CSS with our current code style. This is working fine so

@ffoodd forgot the & and now it scopes a child element 😉

[ffoodd]

Oh my, thanks :D

[GeoSot]

It's ALIVE again :D