-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cspell to Actions #35593
Move cspell to Actions #35593
Conversation
.github/workflows/cspell.yml
Outdated
- name: Run cspell | ||
uses: streetsidesoftware/cspell-action@v1.3.5 | ||
with: | ||
files: "site/**/*.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we can move this in .cspell.json too? That way everything should work without any arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if it can help but instead of cspell \"site/**/*.md\" --no-progress
, it it possible to manually launch cspell --no-progress
and to define the path to analyze in your .cspell.json
by adding:
"files": [
"site/**/*.md"
]
It will maybe work as well with streetsidesoftware/cspell-action@v1.3.5
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, I'll try that, thanks!
@coliff can you confirm if the above works for your use case through an editor?
BTW there's a gitignore
option we could add in the config. I'm trying to figure out if it's enabled by default or not.
good idea to move cspell to a GitHub Action - I recently started doing this myself. Perhaps consider adding the following options to
So that typos are reported but it won't fail (to make it less annoying for any false-positives). REF: https://github.com/streetsidesoftware/cspell-action#usage |
ca7b29c
to
7fc3731
Compare
|
b93cc27
to
01dc15d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``
35288db
to
20bd677
Compare
015036b
to
ba051fe
Compare
Requires #35573 and #35680