_custom-forms.scss: fix order of attributes #36231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong order of attributes
There was a problem hiding this comment.
Sounds good to me.
Even if the order in this case doesn't matter since it works both ways, IMHO it still brings more consistency in the v4 source code; borders are always defined as width then style then color in other files.
Note for maintainters: Label (and project reference) should be v4 instead of v5
XhmikosR
approved these changes
May 14, 2022
XhmikosR
changed the title
This was referenced Sep 23, 2024
This was referenced Sep 30, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong order of attributes