Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accNames to all progress bar examples #36732

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Add accNames to all progress bar examples #36732

merged 4 commits into from
Jul 13, 2022

Conversation

patrickhlauke
Copy link
Member

  • also expands advice in progress.md, explicitly mentions giving them an accName, and includes the callout about using color to convey meaning
  • updates cheat sheets, but note that for the RTL one, my arabic is...lacking. we should get somebody who knows what they're doing to translate those aria-labels properly

Closes #36714

@patrickhlauke
Add accNames to all progress bar examples
efd7180 
* also expands advice in progress.md, explicitly mentions giving them an accName, and includes the callout about using color to convey meaning
* updates cheat sheets, but note that for the RTL one, my arabic is...lacking. we should get somebody who knows what they're doing to translate those `aria-label`s properly

Closes #36714
This was referenced Jul 13, 2022
Closed
Closed
@julien-deramond julien-deramond self-requested a review July 13, 2022 15:39
julien-deramond
julien-deramond requested changes Jul 13, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this PR @patrickhlauke.
Just a small change proposed for consistency.
Regarding the arabic version (RTL) we could maybe ask in the Slack general channel for some translation if anyone can help use in the community 🤷

site/content/docs/5.2/examples/cheatsheet-rtl/index.html Outdated Show resolved Hide resolved
@patrickhlauke @julien-deramond
Update site/content/docs/5.2/examples/cheatsheet-rtl/index.html
9e5b95c 
ah good catch

Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@julien-deramond julien-deramond self-requested a review July 13, 2022 18:45
@julien-deramond
Copy link
Member

julien-deramond commented Jul 13, 2022 •
edited
Loading

I've seen in the history the great work you've done on updating RTL examples @aqeelat in #33097.
In this PR we have new texts (new aria-labels for a better accessibility) that would need to be translated for the RTL Cheatsheet example. Would you be able to help us translating them? 🙏

List of texts:

  • "Example with label"
  • "Success example with label"
  • "Info example with label"
  • "Warning example with label"
  • "Danger example with label"
  • "Segment one - default example"
  • "Segment two - animated striped success example"

@aqeelat
Copy link
Contributor

aqeelat commented Jul 13, 2022

Can I paste the translations here? @julien-deramond

@julien-deramond
Copy link
Member

Can I paste the translations here? @julien-deramond

Yes sure. Thanks a lot <3

@aqeelat
Copy link
Contributor

aqeelat commented Jul 13, 2022

  • "Example with label" -> "مثال مع عنوان"
  • "Success example with label" -> "مثال ناجح مع عنوان"
  • "Info example with label" -> "مثال توضيح مع عنوان"
  • "Warning example with label" -> "مثال تنبيه مع عنوان"
  • "Danger example with label" -> "مثال خطر مع عنوان"
  • "Segment one - default example" -> "القسم الأول - مثال افتراضي"
  • "Segment two - animated striped success example" -> "القسم الثاني - مثال ناجح مقلّم متحرك"

Sorry for the delay.
Let me know if there is anything else I can do to help with bootstrap's RTLization.

@julien-deramond @mdo

@julien-deramond @aqeelat
Add translations
170cf82 
Co-authored-by: Abdullah Alaqeel <abdullah.t.aqeel@gmail.com>
@julien-deramond julien-deramond merged commit 8bb68b0 into main Jul 13, 2022
@julien-deramond julien-deramond deleted the patrickhlauke-issue36714 branch July 13, 2022 21:31
@patrickhlauke
Copy link
Member Author

wonderful, thank you @aqeelat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
accessibility backport-to-v4 docs examples
Projects
No open projects
v5.2.0-stable
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress Bar Examples have accessibility issues
4 participants
@patrickhlauke @julien-deramond @aqeelat @mdo