-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tooltip selector usage #36914
Fix tooltip selector usage #36914
Conversation
With this fix, we will able to keep |
You may do a test on your code using this script Note: the only sure is that can be reverted just letting |
I think this PR doesn't resolve #36813 (my issue). I setted up Look at this code pen, it's exactly the code I use: https://codepen.io/BrokenSourceCode/pen/PoRBzKv. |
f156f8c
to
c5194da
Compare
Thank you for your test. I reverted the change of |
@GeoSot I have already planned to replace my code. You don't need to revert previous commits for the issue I encountered, not for me. |
c5194da
to
5cc297d
Compare
@julien-deramond what is your opinion? May I drop 5cc297d or not? |
5cc297d
to
12e3e60
Compare
IMHO setting the title to an empty string is not a good practice and can lead to bad usage. Since the first commit fixes the 2 issues, I'd drop 5cc297d. |
0fb6127
to
d7dcbbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had the time to do more than the following tests to review this PR so that it could be embedded in the v5.2.1:
- Tooltips with native HTML title attribute not working on dynamically created elements #36895 is well fixed and represented by a visual test
- Non-regression testing OK for tooltips and popovers in the documentation
- Only read the source code that seems OK but haven't tested it in details. Sorry for that
d7dcbbc
to
8801dba
Compare
8801dba
to
34f3e00
Compare
As quick fix as many people seems to use old 'black magic' stuff.
NOTE: Please do not use
data-bs-original-title
.It returned, just to support the strange cases where tooltip are created through selector
(explanation: a falsie tooltip is created on a wrapper and adds delegated event listeners),
but for some strange reason, new tooltips are supposed to show the same title as the first ones, or to be initialized from a data-attribute that shouldn't exist (
title
) after the initializationcloses #36895
ref #36813