docs: update v5 version docs version dropdown to include updated v5.2 dropdown #37002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
This is great, tested out locally and it looks good! The reason the CSS doesn't work for you most likely is that you need to start a local server (try starting a local Python server or something similar if you like). |
Yeah I realized like a day after that everything would just be cors blocked since I only opened the html file. That and it may also get blocked by browsers for not allowing access to file systems. Regardless 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the v5.1 and v5.0 dropdowns to include the updated v5.2 dropdown. They both now include the actual v5.2 as latest. In my dev environment, I checked that each had the correct dropdown, but my dev environment did not include the css. Everything functionally worked, but please checkout and make sure everything looks correct. I didn't spend a huge amount of time on it and didn't want to figure out why the css wasn't loading. ✌️ Also, here was my original issue #36990