-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: replace twbs/bootstrap-npm-starter
by twbs/examples/tree/main/icons-font
#37671
Conversation
81eba32
to
6ce7485
Compare
twbs/bootstrap-npm-starter
by twbs/examples/tree/main/icons-font
I think https://github.com/twbs/examples/tree/main/sass-js or https://github.com/twbs/examples/tree/main/sass-js-esm is a better fit here instead of the Icons example which doesn't compile Bootstrap's source Sass code at all. Thoughts? |
I can replace in this PR https://github.com/twbs/examples/tree/main/icons-font with https://github.com/twbs/examples/tree/main/sass-js as suggested and in a second time recreate the starter template in https://github.com/twbs/examples which is mayble more complete? |
6ce7485
to
58ab6bf
Compare
Updated it to replace the links as mentioned. Also updated the starter template's CSS, so this is now dependent on the icon link addition, and fixes the |
58ab6bf
to
4353a07
Compare
4353a07
to
9649f86
Compare
Bootstrap 4 is EOL in few weeks.
It means that https://github.com/twbs/bootstrap-npm-starter shouldn't be referenced anymore in our latest documentation. And that it could probably by archived.
This PR suggested that all references to https://github.com/twbs/bootstrap-npm-starter are changed to use the closest already existing example we have... and it seems to be https://github.com/twbs/examples/tree/main/icons-font.
This PR also suggest to update the Starter template example page to add references to our other examples.
This version tries not to modify too much wording and references by keeping the notion of "npm started" even if our example is rather named "Bootstrap Icons", but we can go further.
/cc @mdo
Type of changes
Checklist
npm run lint
)Live previews