Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scss tests work on Windows too #37713

Merged
merged 2 commits into from
Dec 25, 2022
Merged

Make scss tests work on Windows too #37713

merged 2 commits into from
Dec 25, 2022

Conversation

XhmikosR
Copy link
Member

Fixup after #36029

@XhmikosR
Make scss tests work on Windows too.
daa765a 
Also, add missing `'use strict'` statements; these aren't real modules.
@XhmikosR XhmikosR marked this pull request as ready for review December 25, 2022 10:29
@XhmikosR XhmikosR requested a review from a team as a code owner December 25, 2022 10:29
@XhmikosR XhmikosR mentioned this pull request Dec 25, 2022
Merged
mdo
mdo approved these changes Dec 25, 2022
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@XhmikosR XhmikosR merged commit d891159 into main Dec 25, 2022
@XhmikosR XhmikosR deleted the xmr/fix-scss-tests branch December 25, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
tests v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @mdo