-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce size of guide dev server images #37741
Conversation
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 17.2%, saving 38.82 KB.
99 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
I'll have a pass at those. None of the tools out there achieve the best compression AFAICT. EDIT: ...and you can easily see the above from the fact that calibre action optimized them 😛 EDIT2: the gh-pages branch is only updated when a release is made, unless it's something that doesn't apply to main or is super-important. |
When I said we probably want to update |
Yeah, we don't touch the old versions unless it's something really important, which in this case it isn't. |
I can re-export the source at a specific size. I'd suggest a minimum of 2x the widest content width (805px), which is 1610px. That way we keep retina quality 2x. We could do a 1x version though for smaller ones. Thoughts @XhmikosR? |
Sounds good to me, @mdo. I'll compress the newly exported images then. |
Description
This PR suggests to reduce the size of the
static/docs/5.3/assets/img/guides/*-dev-server*.png
images which were 2280px width.I've chosen arbitrarily a value of 1000px width (like some in this same directory) and used https://www.iloveimg.com online tool.
This PR can be closed if this topic has already been mentioned/tackled before or if we want to use other values or tools to do that.
If this PR is merged, we probably want to update them in our
gh-pages
branch.Motivation & Context
Save some trees.
Type of changes
Checklist
Live previews