Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snippet examples for dark mode #37834

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Update snippet examples for dark mode #37834

merged 4 commits into from
Jan 11, 2023

Conversation

mdo
Copy link
Member

@mdo mdo commented Jan 7, 2023

Updates all eight snippet examples to use new classes from shipping dark mode. Builds on and assumes the changes from #37832 and #37833.

@mdo mdo requested a review from a team as a code owner January 7, 2023 23:59
@mdo mdo force-pushed the darkmode-examples branch from 9d641d7 to 50496a1 Compare January 8, 2023 00:09
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked everything in details. Few comments to tackle before merging but great update! Thanks!

@mdo mdo force-pushed the darkmode-examples branch from ad50d44 to a251928 Compare January 11, 2023 00:24
@mdo mdo merged commit f40e76d into main Jan 11, 2023
@mdo mdo deleted the darkmode-examples branch January 11, 2023 00:33
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants