Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chip component #37846

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add chip component #37846

wants to merge 7 commits into from

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jan 9, 2023

Warning
Heavily WIP

Description

Heavily WIP but wanted to show something as a possible implementation for Chips.

It's far for being perfect since I haven't spent too much time on it. Just tried quickly to get back what we developed for our Tags component at Orange and to tweaked it (not very well) to Bootstrap style.

Just would like your opinion on starting from that or do you prefer to start from scratch?

Type of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #31033

@julien-deramond
Copy link
Member Author

I've seen in https://deploy-preview-36309--twbs-bootstrap.netlify.app/docs/5.3/examples/badges/ that maybe a chip would be a badge?

@mdo
Copy link
Member

mdo commented Jan 11, 2023

Could be! Those snippets are far from perfect, and might not make sense to repurpose for a new overall component, but maybe they could! Let's think on it ahead of starting v6 :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

Add chips
3 participants