Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to avoid creating void elements in tooltip test file #38034

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

julien-deramond
Copy link
Member

Minor modification to avoid using <a>s as void elements in tooltip.spec.js. Some were already modified this way and some not yet, so this PR brings some consistency in our use cases as well and corresponds better to what's described in the second test described in https://github.com/twbs/bootstrap/tree/main/js/tests#example-tests.

@julien-deramond julien-deramond marked this pull request as ready for review February 11, 2023 08:12
@julien-deramond julien-deramond requested a review from a team as a code owner February 11, 2023 08:12
@julien-deramond julien-deramond merged commit f5f6c5c into main Feb 11, 2023
@julien-deramond julien-deramond deleted the main-jd-fix-non-void-element-tooltip branch February 11, 2023 09:18
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants