Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $grid-breakpoints SCSS unit tests init #38037

Merged

Conversation

julien-deramond
Copy link
Member

Description

This PR changes the values of $grid-breakpoints in scss/tests/utilities/_api.test.scss to be sure that this value is well overriden. Since it was not the case, also added a !global.

If you need to manually test this modification, you can remove the !global and you'll see that even if we expect to change the small and medium values respectively to 333 and 666, the test still passes.

Motivation & Context

Unit test worked because $grid-breakpoints contained the same values for small and medium breakpoints so we didn't detect that the overriden value didn't work.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@julien-deramond julien-deramond merged commit 80a5266 into main Feb 13, 2023
@julien-deramond julien-deramond deleted the main-jd-fix-grid-breakpoints-scss-unit-test-init branch February 13, 2023 18:46
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants