Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: drop unused icons #38103

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Docs: drop unused icons #38103

merged 2 commits into from
Feb 23, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 22, 2023

Description

Drop unused icons in the project.

  • Based on d70b5db, dropped arrow-right-short which is now used only in examples that declare the SVG on top of the files. So arrow-right-short is not used anymore in the rest of the documentation
  • In the same spirit, I've checked all the site/layouts/partials/icons.html. Everything's used except maybe list; I don't think it is used but I was too afraid to have a regression (searching "list" in our project is a nightmare).
  • While I was checking it, I also checked unused icons on top of the examples. Here are the lists of modified examples that need to be double-checked while reviewing this PR for non-regression:

Motivation & Context

Lighten our files.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review February 22, 2023 10:22
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julien-deramond julien-deramond merged commit 78f879e into main Feb 23, 2023
@julien-deramond julien-deramond deleted the main-jd-drop-unused-icon branch February 23, 2023 06:55
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants