-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: color mode enhancement #38144
Conversation
I was thinking about it with the first version that uses the current color mode. Totally agree that this is way better to change it directly within the examples but I didn't know how. Not a big fan of having an extra bar right now; especially in the navbars examples. But I can't find another way of doing it. Another option could be to display the toggle in absolute position on a corner of the window; on top of everything in the same spirit as back-to-top buttons. But it might block the navigation in some use cases. And it should be accessible for keyboard users as well. Or maybe something semi-hidden on the top right or left corner of the page like this skip links menu in Storybook (accessible and maybe with a bigger surface to see that there's actually something to click on): |
Thanks @mdo for 81f2f86. Sounds better, and less intrusive than a header. |
3c252f4
to
3551e1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
Description
Adding a theme toggle in each example.
Some small tweaks on some examples for the color mode.
Motivation & Context
Better change the color mode inside examples
Type of changes
Checklist
npm run lint
)Live previews
Related issues
NA
Still todo
See if a fixed dropdown would be better.
Set a partial for this dropdown.
Need to be merged with #38058 ?