Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buttons.md #38169

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Update buttons.md #38169

merged 2 commits into from
Mar 10, 2023

Conversation

mdo
Copy link
Member

@mdo mdo commented Mar 5, 2023

Updates the buttons documentation to refer to the button styles as variants as opposed to "predefined styles" as that language was previously troublesome elsewhere in our docs, and variants makes more sense.

Updates the buttons documentation to refer to the button styles as variants as opposed to "predefined styles" as that language was previously troublesome elsewhere in our docs, and variants makes more sense.
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion in the first paragraph of "Variants". Otherwise LGTM, it's better with variants yes :)

site/content/docs/5.3/components/buttons.md Outdated Show resolved Hide resolved
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@mdo mdo merged commit 6f18ad9 into main Mar 10, 2023
@mdo mdo deleted the mdo-patch-1 branch March 10, 2023 18:36
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants