Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak stylelint config #38228

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Tweak stylelint config #38228

merged 3 commits into from
Mar 15, 2023

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 14, 2023 •
edited
Loading

  • move reportInvalidScopeDisables and reportNeedlessDisables to config
  • rename to .stylelintrc.json
  • inherit from the root config
  • remove unneeded disabled from examples/.stylelintrc.json

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR marked this pull request as ready for review March 14, 2023 06:57
@XhmikosR XhmikosR requested a review from a team as a code owner March 14, 2023 13:02
@XhmikosR XhmikosR changed the title Stylelint: move reportInvalidScopeDisables and reportNeedlessDisables… Tweak stylelint config Mar 14, 2023
@XhmikosR
Copy link
Member Author

I believe this is now ready. IMHO it's cleaner now.

The only issue I've been hitting is some caching issue when changing the config. But it's not something new IIRC.

@XhmikosR
Copy link
Member Author

Now that I think about it, it might make more sense to merge the examples config with the root one so that we have everything in one place.

I'll give it a go later and I'd all goes well I'll merge it.

@XhmikosR XhmikosR requested a review from a team as a code owner March 14, 2023 18:38
@XhmikosR
Tweak stylelint config
096fb65 
* move reportInvalidScopeDisables and reportNeedlessDisables to config
* rename to .stylelintrc.json
* inherit from the root config
* remove unneeded disabled from examples/.stylelintrc.json
@XhmikosR
Merge the two configs
eca9f65
@XhmikosR
Copy link
Member Author

OK, now I really think it's ready :) Let me know which approach you prefer. I feel the latter is cleaner since those rules affect our Sass files only and we reduce the overrides.

mdo
mdo approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@XhmikosR XhmikosR merged commit c400653 into main Mar 15, 2023
@XhmikosR XhmikosR deleted the xmr/stylelint-rd branch March 15, 2023 04:30
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
build v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @mdo