Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: consistent deprecation messages in Close Button dark variant #38247

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Mar 16, 2023

Description

Several dark variants of components are deprecated in v5.3.0.
Close button message regarding this deprecation is not correctly aligned with the one from the dark carousels for example (see https://twbs-bootstrap.netlify.app/docs/5.3/components/carousel/#dark-variant).

This PR suggests to:

  • add the deprecated-in shortcode
  • change the level of the "Heads up!" message from info to warning

Motivation & Context

Consistency in the doc.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review March 16, 2023 08:36
@XhmikosR XhmikosR merged commit 4ba2deb into main Mar 16, 2023
@XhmikosR XhmikosR deleted the main-jd-consistent-deprecation-msg-of-dark-variant branch March 16, 2023 16:22
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants