Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use border-radius CSS variables in more components #38284

Merged
merged 2 commits into from
Mar 25, 2023
Merged

Use border-radius CSS variables in more components #38284

merged 2 commits into from
Mar 25, 2023

Conversation

jonnysp
Copy link
Contributor

@jonnysp jonnysp commented Mar 20, 2023 •
edited
Loading

missing global variable border-radius

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@jonnysp
Update _variables.scss
1aa8a7f 
missing global variable on nav-pills-border-radius
@jonnysp jonnysp requested a review from a team as a code owner March 20, 2023 10:19
@jonnysp jonnysp changed the title missing global variable on nav-pills-border-radius missing global variable border-radius Mar 20, 2023
@mdo mdo changed the title missing global variable border-radius Use border-radius CSS variables in more components Mar 25, 2023
@mdo mdo merged commit 3b9b154 into twbs:main Mar 25, 2023
@mdo
Copy link
Member

mdo commented Mar 25, 2023

Thanks!

@jonnysp jonnysp deleted the nav-pills-border-radius branch March 28, 2023 06:28
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.3.0-alpha3
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonnysp @mdo @julien-deramond