Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: remove moot hot option from Vite guide #38405

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Docs: remove moot hot option from Vite guide #38405

merged 1 commit into from
Apr 5, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Apr 4, 2023 •
edited
Loading

Description

This PR removes the moot hot option from the Vite config example in the docs.

Motivation & Context

Vite config example must be updated after twbs/examples#157.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review April 4, 2023 15:57
@julien-deramond julien-deramond requested a review from XhmikosR April 4, 2023 15:57
@XhmikosR XhmikosR added the skip-changelog So that the release drafter action doesn't include it label Apr 5, 2023
@XhmikosR XhmikosR merged commit b62fd60 into main Apr 5, 2023
@XhmikosR XhmikosR deleted the main-jd-remove-moot-hot-vite-config branch April 5, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
docs skip-changelog So that the release drafter action doesn't include it v5
Projects
No open projects
v5.3.0-stable
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-deramond @XhmikosR