Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-sass workflow: improve error message when Sass vars are found #38448

Merged
merged 11 commits into from
Apr 13, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Apr 12, 2023

Description

This PR suggests improving the error message of the node-sass workflow when we find Sass variables in dist-sass.

In the first commit, I voluntarily reverted some changes in our CSS files in https://github.com/twbs/bootstrap/pull/38448/files to show the new error message.
It can be found here: https://github.com/twbs/bootstrap/actions/runs/4679714004/jobs/8290111973?pr=38448.

Screenshot 2023-04-12 at 16 53 32

Then, the second commit rollbacks the wrong changes so that the workflow is green again.

Extra information: bash {0} is used to avoid "Fail-fast behavior" (See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference)

Motivation & Context

When it's not possible to run npx locally because of security rules in a company or because you don't remember the command line, it can be really handy to have the list of the errors directly in the logs of the failed workflow.

Type of changes

  • Enhancement (non-breaking change which adds functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

@julien-deramond julien-deramond marked this pull request as ready for review April 12, 2023 16:29
@XhmikosR XhmikosR force-pushed the main-jd-improve-log-of-node-sass-workflow branch from 620dddd to 6d80576 Compare April 13, 2023 06:26
@XhmikosR XhmikosR force-pushed the main-jd-improve-log-of-node-sass-workflow branch from 6d80576 to 13c031d Compare April 13, 2023 06:29
@XhmikosR XhmikosR force-pushed the main-jd-improve-log-of-node-sass-workflow branch from 13c031d to 8035fe2 Compare April 13, 2023 06:33
@XhmikosR XhmikosR requested a review from a team as a code owner April 13, 2023 06:34
@XhmikosR XhmikosR force-pushed the main-jd-improve-log-of-node-sass-workflow branch from ff6792a to 8035fe2 Compare April 13, 2023 06:36
@XhmikosR XhmikosR changed the title Workflows: improve node-sass error message when Sass vars are found node-sass workflow: improve error message when Sass vars are found Apr 13, 2023
@XhmikosR XhmikosR merged commit 5e3dc58 into main Apr 13, 2023
@XhmikosR XhmikosR deleted the main-jd-improve-log-of-node-sass-workflow branch April 13, 2023 06:47
@XhmikosR XhmikosR added the CI label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants