Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#38769 text-bg-primary now respects --bs-primary color #38770

Closed

Conversation

cameronhollis
Copy link
Contributor

@cameronhollis cameronhollis commented Jun 14, 2023

Description

Changed .text-bg-primary, .text-bg-secondary, etc to use their respective --bs-___-rgb variables instead of hard coded values.

Motivation & Context

This change solves the problem brought up in Issue #38769: text-bg-primary does not respect --bs-primary color.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

#38769

@julien-deramond
Copy link
Member

As mentioned in our Contributing Guidelines:

Do not edit bootstrap.css or bootstrap.js, and do not commit any dist files (dist/ or js/dist). Those files are automatically generated by our build tools. You should edit the source files in /bootstrap/scss/ and/or /bootstrap/js/src/ instead.

@cameronhollis cameronhollis deleted the text-bg-primary-branch-fix branch June 14, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants