Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix carousel carousel colors of carousel examples in dark mode #38840

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jun 27, 2023

Description

This PR removes the unnecessary data-bs-theme="light" from the carousel markup in both the LTR and RTL carousel examples.

Motivation & Context

The rendering in dark mode was not working properly because of the data-bs-theme="light" attribute:

Screenshot 2023-06-27 at 21 29 37

Please double-check that the rendering in dark mode is considered as fitting the global design.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Please test these URLs in light and dark mode:

@julien-deramond julien-deramond marked this pull request as ready for review July 7, 2023 06:07
@mdo mdo merged commit 101ff73 into main Jul 17, 2023
@mdo mdo deleted the main-jd-fix-carousel-example-dark-mode-colors branch July 17, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants