Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SASS deprecated lighten, darken and color methods #40865

Closed
wants to merge 2 commits into from

Conversation

ghiscoding
Copy link

@ghiscoding ghiscoding commented Sep 21, 2024

Description

fixes issue #40849

Motivation & Context

latest SASS version v1.79.x and higher are now showing a bunch of deprecation warnings as shown below.

image

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@ghiscoding ghiscoding requested a review from a team as a code owner September 21, 2024 19:59
@ghiscoding ghiscoding changed the title fix: SASS deprecated lighten, darken and rgb methods fix: SASS deprecated lighten, darken and color methods Sep 21, 2024
@julien-deramond
Copy link
Member

Thanks for your work here @ghiscoding
However, Bootstrap 5 still needs to support node-sass, so we can't use sass:color as done in this PR (see #40864 (comment)).
Thanks for your work on this! I'm going to close it for now to help keep our backlog manageable. Feel free to reopen it if you come up with a different or new solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants