Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler tooltip initialization #40959

Closed
wants to merge 2 commits into from
Closed

Simpler tooltip initialization #40959

wants to merge 2 commits into from

Conversation

fulldecent
Copy link
Contributor

@fulldecent fulldecent commented Oct 19, 2024 •
edited
Loading

Description

Simpler way to initialize tooltips

Motivation & Context

This is boilerplate code I use on every page everywhere. A little golfing may be in order :-)

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

n/a

Previously we were targeting browsers that do not support `NodeList.prototype.forEach.

Now all our supported browsers do. Source: https://caniuse.com/mdn-api_nodelist_foreach

@julien-deramond julien-deramond requested a review from a team October 19, 2024 16:33
@XhmikosR XhmikosR closed this Oct 19, 2024
@fulldecent
Copy link
Contributor Author

@XhmikosR thanks for the review. Any notes? Anything I can fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs js v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulldecent @XhmikosR @julien-deramond