Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Modernize footer design and improve visual hierarchy #40969

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SuhaniBh
Copy link

@SuhaniBh SuhaniBh commented Oct 22, 2024

Description

The current Bootstrap footer design, while functional, can benefit from modern design principles to enhance visual appeal and user experience. This PR modernizes the footer with improved spacing, typography, and visual hierarchy while maintaining its core functionality.

Motivation & Context

This change improves the visual presentation of Bootstrap's documentation footer by:

  • Enhancing readability with better spacing and typography
  • Implementing a more modern color scheme with subtle backgrounds
  • Adding smooth hover interactions for better user feedback
  • Improving mobile responsiveness and content organization
  • Maintaining accessibility standards while upgrading the design

Type of changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

  • N/A - Enhancement proposal for footer design modernization

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the PR, @SuhaniBh!

There are a few code issues that need addressing, but let's hold off on fixing them until we hear back from @mdo (who designs Bootstrap) about the design. We don't want to spend time on code adjustments if the rendering doesn't meet the design expectations.

On a personal note, though I'm not a designer, I find the light version a bit too colorful. I also think the logo and 'Bootstrap' text shouldn't be blue.

</ul>
</div>
</div>
</div>
</footer>

<style>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page can't use <style>, the CSS part should be put inside the corresponding (S)CSS file.

<li class="mb-3"><a href="{{ .Site.Params.github_org }}/bootstrap/discussions" target="_blank" rel="noopener" class="text-decoration-none text-body-secondary hover-primary">Discussions</a></li>
<li class="mb-3"><a href="https://github.com/sponsors/twbs" target="_blank" rel="noopener" class="text-decoration-none text-body-secondary hover-primary">Corporate sponsors</a></li>
<li class="mb-3"><a href="{{ .Site.Params.opencollective }}" target="_blank" rel="noopener" class="text-decoration-none text-body-secondary hover-primary">Open Collective</a></li>
<li class="mb-3"><a href="https://stackoverflow.com/questions/tagged/bootstrap-5" target="_blank" rel="noopener" class="text-decoration-none text-body-secondary hover-primary">Stack Overflow</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the links style, it should be handled in the corresponding (S)CSS file, not by repeating classes all over the file.

<footer class="bd-footer py-5 mt-5 bg-primary-subtle">
<div class="container py-5 px-4 px-md-3">
<div class="row g-4">
<!-- Brand Column -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments added in this PR can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

2 participants