Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #4550 button dropdowns not working on mobile devices #5278

Closed
wants to merge 2 commits into from

Conversation

stevecoug
Copy link

This is a fix for issue #4550 "Button dropdown links don't work on mobile (android, iOS)" based on these comments:

#4550 (comment)
#4550 (comment)
#4550 (comment)

@danielboendergaard
Copy link
Contributor

This doesn't work for submenus

@stevecoug
Copy link
Author

I don't actually use submenus on my site, so I didn't test that. Does adding #4550 (comment) fix the submenu problem?

@danielboendergaard
Copy link
Contributor

It doesn't work on my Android phone, I'll try it on the iPad tomorrow :)

@andrewdeandrade
Copy link

Hey @fridgesm,

Thanks for opening this pull-request! Unfortunately, it looks like it fails to pass the criteria neccessary for submitting to bootstrap. The following things are currently failing:

  • should always be made from feature branches
  • should always include a unit test if changing js files

For a full list of issue filing guidelines, please refer to the bootstrap issue filing guidelines.

thanks!

@blakeembrey
Copy link
Contributor

@fridgesm Wouldn't you just combine the two .dropdown and .dropdown-menu rules into one event? Also, this issue should already be fixed with my PR - #5067

@timeturner
Copy link

Can the pull request for this please be accepted. It's really not helping the mobile experience for bootstrap to have issues with touch events when the majority of your visitors are from mobile. I've had to replace the button when the window get's resized for this reason as a temp fix but I would really like to have the button back.

Thanks

@fred
Copy link

fred commented Oct 9, 2012

👍
Please merge this :)
Drop down menus are not working for Google Chrome on Android

@fat
Copy link
Member

fat commented Oct 18, 2012

duplicate of #5067

@fat fat closed this Oct 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants