Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added item as object option (json objects), destroy method, override ren... #8257

Closed
wants to merge 1 commit into from

Conversation

Leonidaz
Copy link

...der for templating

  • added storage of item in data('ta-data-value') instead of attr('data-value') to accomodate for item objects like json (vs item as string)
  • add valKey to defaults to accommodate item as object (vs item as string)
  • for dev added jshint asi: true to disable semicolor checker of jslint
  • added destroy method with teardown
  • added stoplisten method to off events (called by destroy)
  • added .typeahead.instance namespace to events for easy removal
    e.g. focus.typeahead.instance
  • added override for render and select methods to provide custom template

…render for templating

* added storage of item in data('ta-data-value') instead of attr('data-value') to accomodate for item objects like json (vs item as string)
* add valKey to defaults to accommodate item as object (vs item as string)
* for dev added jshint asi: true to disable semicolor checker of jslint
* added destroy method with teardown
* added stoplisten method to off events (called by destroy)
* added .typeahead.instance namespace to events for easy removal
  e.g. focus.typeahead.instance
* added override for render and select methods to provide custom template
@mdo
Copy link
Member

mdo commented Jun 22, 2013

Typeahead is being dropped in v3 (see #7805 and 88dd9de), and we also don't accept pull requests against master. Thanks though!

@mdo mdo closed this Jun 22, 2013
@Leonidaz
Copy link
Author

yes, i saw about the pull requests against master but -wip branch didn't have typeahead - and, so, it's being dropped. well, hopefully, somebody might find this useful. thanks for replying.

@mdo
Copy link
Member

mdo commented Jun 22, 2013

Word. I was thinking more about it and perhaps we keep it around as a plugin when v3 launches? I'll talk to @fat about that to see if it's doable. If we can just keep it as an "archived project" there for basic bugfixes and what not, that'd probably be super useful for folks. And then we can revisit stuff like this :).

@Leonidaz
Copy link
Author

thanks, that sounds like a good idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants