add dynamicPlacement tooltip option
#8398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2013
|
Would this also work for popover by extension? |
|
@ncatanchin As with the original pull request, indeed it does. |
|
Worthy alternative: #7996 |
|
why not just piggy back on the placement option?
|
| @@ -1167,6 +1168,29 @@ | |||
| var actualWidth = $tip[0].offsetWidth | |||
| var actualHeight = $tip[0].offsetHeight | |||
|
|
|||
| if (this.options.dynamicPlacement) { | |||
| var con = this.$element.parent() | |||
This is a port to the latest 3.0.0-wip (with some cosmetic code changes) of #6848 by Nick Roberts <nick@utropicmedia.com> (@nickroberts)
|
@fat: Because, as currently written, it uses |
|
got a version of this in 3.0.0 - thanks |
|
217eb98 Cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of @nickroberts having had to wait ~5 months to get action on his pull request from @fat, I've taken the liberty of porting (with some cosmetic code changes) #6848 to the current latest
3.0.0-wip, to save him the trouble.The automated tests still pass and it indeed seems to work based on limited manual testing.