Workaround for #9023. #9339
Closed
Workaround for #9023. #9339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming there isn't some more elegant solution, this might be a candidate for the docs, ala #9171. |
Conflicts: dist/css/bootstrap.min.css dist/js/bootstrap.js dist/js/bootstrap.min.js js/modal.js
|
Done in #9341. |
Conflicts: dist/css/bootstrap.min.css dist/js/bootstrap.min.js Fixed by rebuilding.
|
not the right solution for core, thanks though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ugly fix for #9023.
We make the background and the container fill the entire document. We can then scroll as normal within the document, and we aren't using fixed anywhere, as the virtual keyboard breaks that.
To get the modal into the right place, we add padding to the current scroll position.
This will break if the page changes shape (shouldn't happen on iOS, basic rotation is fine). It also sniffs for iOS, which isn't great, but I can't see another way.
So overall this is a pretty nasty fix, and I wouldn't blame you for not merging it, but it may be of interest to someone with the same problem as me. It works fine for my use case.