Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs.css issue #390

Closed
XhmikosR opened this issue Mar 3, 2014 · 4 comments · Fixed by #463
Closed

docs.css issue #390

XhmikosR opened this issue Mar 3, 2014 · 4 comments · Fixed by #463

Comments

@XhmikosR
Copy link
Member

XhmikosR commented Mar 3, 2014

When this is included here it results in the following:

.platform-ios {
  @-webkit-keyframes fadeOverlay {
    from {
      -webkit-box-shadow: 0 0 10px rgba(0, 0, 0, 0), -320px 0 0 rgba(0, 0, 0, 0);
      box-shadow: 0 0 10px rgba(0, 0, 0, 0), -320px 0 0 rgba(0, 0, 0, 0);
    }

    to {
      -webkit-box-shadow: 0 0 10px rgba(0, 0, 0, 0.3), -320px 0 0 rgba(0, 0, 0, 0.1);
      box-shadow: 0 0 10px rgba(0, 0, 0, 0.3), -320px 0 0 rgba(0, 0, 0, 0.1);
    }
}

This isn't valid CSS and it breaks many tools like clean-css.

/CC @connor @connors

@connors
Copy link
Collaborator

connors commented Mar 3, 2014

Yes @mdo and I were talking about this over the weekend. We need to figure out another way to get the different animations to work with the specific platform examples.

We can always just override them in the docs css.

@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 3, 2014

This was the reason clean-css fails with advanced optimizations enabled btw. I filled a bug report upstream, but I'm not sure if this will be fixed since it's wrong CSS syntax...

@zlatanvasovic
Copy link
Contributor

This is a Sass bug, should we report it?

@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 4, 2014

When this is fixed, we should revert bafe784 and make sure everything works fine again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants