Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable JS strict mode #302

Closed
wants to merge 1 commit into from
Closed

Enable JS strict mode #302

wants to merge 1 commit into from

Conversation

zlatanvasovic
Copy link
Contributor

Fixes #285.

@@ -1,8 +1,10 @@
// FINGERBLAST.js
// --------------
// Adapted from phantom limb by brian cartensen
// Adapted from phantom lib by Brian Cartensen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cvrebert
Copy link
Contributor

Have you checked that the current code actually complies with strict mode?

@zlatanvasovic
Copy link
Contributor Author

It works on Chrome Android, I don't know for iOS.

@cvrebert cvrebert added the js label Feb 26, 2014
@XhmikosR
Copy link
Member

XhmikosR commented Mar 3, 2014

This breaks the /components navbar. :/

Something bad happens in that code since I'm having issues with it too.

@zlatanvasovic
Copy link
Contributor Author

Urgh. There are some quircks to be fixed.

/cc @connor

@XhmikosR
Copy link
Member

XhmikosR commented Mar 3, 2014

I think it might be wiser to cherry pick this commit into the JSHint branch so that we can all work on it.

@zlatanvasovic
Copy link
Contributor Author

I can't work on twbs/ratchet branches.

2014-03-03 10:50 GMT+01:00 XhmikosR notifications@github.com:

I think it might be wiser to cherry pick this commit into the JSHint
branch so that we can all work on it.


Reply to this email directly or view it on GitHubhttps://github.com//pull/302#issuecomment-36494901
.

Zlatan Vasović - ZDroid

@XhmikosR
Copy link
Member

XhmikosR commented Mar 3, 2014

I meant the rest :/

@zlatanvasovic
Copy link
Contributor Author

Hm? If I made the commit I should be able to modify it.

@XhmikosR
Copy link
Member

XhmikosR commented Mar 3, 2014

No one prohibits you to do that in your fork.  Git is flexible enough.

@zlatanvasovic
Copy link
Contributor Author

If you chery-pick the commit and close this pull request I won't be able to
modify commit.

2014-03-03 11:41 GMT+01:00 XhmikosR notifications@github.com:

No one prohibits you to do that in your fork. Git is flexible enough.


Reply to this email directly or view it on GitHubhttps://github.com//pull/302#issuecomment-36498505
.

Zlatan Vasović - ZDroid

@cvrebert
Copy link
Contributor

cvrebert commented Mar 3, 2014

I think #379 has superseded this.

@zlatanvasovic zlatanvasovic deleted the use-strict branch March 3, 2014 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider using JS strict mode
3 participants