-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable JS strict mode #302
Conversation
@@ -1,8 +1,10 @@ | |||
// FINGERBLAST.js | |||
// -------------- | |||
// Adapted from phantom limb by brian cartensen | |||
// Adapted from phantom lib by Brian Cartensen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's "limb" with an "m": https://github.com/brian-c/phantom-limb
Have you checked that the current code actually complies with strict mode? |
Fixes #285
It works on Chrome Android, I don't know for iOS. |
This breaks the /components navbar. :/ Something bad happens in that code since I'm having issues with it too. |
Urgh. There are some quircks to be fixed. /cc @connor |
I think it might be wiser to cherry pick this commit into the JSHint branch so that we can all work on it. |
I can't work on twbs/ratchet branches. 2014-03-03 10:50 GMT+01:00 XhmikosR notifications@github.com:
Zlatan Vasović - ZDroid |
I meant the rest :/ |
Hm? If I made the commit I should be able to modify it. |
No one prohibits you to do that in your fork. Git is flexible enough. |
If you chery-pick the commit and close this pull request I won't be able to 2014-03-03 11:41 GMT+01:00 XhmikosR notifications@github.com:
Zlatan Vasović - ZDroid |
I think #379 has superseded this. |
Fixes #285.