Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing .push-{left,right} to .navigate-{left,right} #362

Merged
merged 6 commits into from
Mar 2, 2014
Merged

Conversation

connors
Copy link
Collaborator

@connors connors commented Mar 1, 2014

We were using .push-left and push-right to add chevrons to elements. This works fine but it's confusing considering we use .pull-left and .pull-right for floating objects. They seem like they'd be related but they're not.

This branch uses .navigate-left and .navigate-right instead.

Fixes #338.

@connors connors added the css label Mar 1, 2014
@connors connors added this to the 2.0.1 milestone Mar 1, 2014
@mdo mdo mentioned this pull request Mar 2, 2014
@mdo
Copy link
Member

mdo commented Mar 2, 2014

:shipit:

connors added a commit that referenced this pull request Mar 2, 2014
Changing .push-{left,right}  to .navigate-{left,right}
@connors connors merged commit c6c7a95 into master Mar 2, 2014
@connors connors deleted the chevrons branch March 2, 2014 00:27
@cvrebert
Copy link
Contributor

cvrebert commented Mar 2, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.push-{left,right} vs .pull-{left,right} seems kinda confusing
3 participants