Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify docs JS files #378

Merged
merged 2 commits into from
Mar 3, 2014
Merged

Minify docs JS files #378

merged 2 commits into from
Mar 3, 2014

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 3, 2014

This fixes #354.

Notes:

1. Unfortunately, for some unknown reason to me yet, the device changer JS doesn't work anymore.
2. I specified compress: true in uglify on purpose so that we see the warnings

/CC @connor @connors: can you check out the branch and see why the aforementioned issue happens?

PS. I'll make another PR for JSHInt.

@XhmikosR XhmikosR added this to the 2.0.1 milestone Mar 3, 2014
@XhmikosR XhmikosR self-assigned this Mar 3, 2014
@zlatanvasovic
Copy link
Contributor

@XhmikosR Partially fixes, not completely fixes.

@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 3, 2014

Fixes just fine for now along with the other PR.

@connor
Copy link
Contributor

connor commented Mar 3, 2014

👍

@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 3, 2014

@connor: I can't merge this due to first issue I mention in the description :P

@connors
Copy link
Collaborator

connors commented Mar 3, 2014

@XhmikosR I just pulled down the branch and everything works fine for me. What browser are you using again?

@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 3, 2014

Let me try again, I might missed refreshing jekyll serve.

@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 3, 2014

Yeah, you are right :)

I'll merge this, but I wish we had better support for development.

XhmikosR added a commit that referenced this pull request Mar 3, 2014
@XhmikosR XhmikosR merged commit 86d2928 into master Mar 3, 2014
@XhmikosR XhmikosR deleted the docs-min-js branch March 3, 2014 18:12
@mdo mdo mentioned this pull request Mar 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow page load
4 participants