Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to "grunt-sass" #479

Merged
merged 2 commits into from
Dec 27, 2015
Merged

Switch to "grunt-sass" #479

merged 2 commits into from
Dec 27, 2015

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR mentioned this pull request Mar 11, 2014
Merged
@XhmikosR XhmikosR added the grunt label Mar 11, 2014
@XhmikosR XhmikosR added this to the 2.0.2 milestone Mar 11, 2014
@XhmikosR XhmikosR self-assigned this Mar 11, 2014
@cvrebert
Copy link
Contributor

What's the deal with the color changes?

@XhmikosR
Copy link
Member Author

I guess a libsass issue...

Apart from the color changes, the fix from #463 doesn't work with grunt-sass. Also, it doesn't follow @at-root nor !global...

Can someone report these issues upstream?

@XhmikosR XhmikosR removed this from the 2.0.2 milestone Mar 12, 2014
@XhmikosR XhmikosR mentioned this pull request Mar 12, 2014
Open
@cvrebert
Copy link
Contributor

They're already aware of the !global bug.

@XhmikosR
Copy link
Member Author

Yeah, I just found the issue sass/libsass#278

@XhmikosR XhmikosR changed the title Switch to "grunt-sass" WIP Switch to "grunt-sass" Mar 25, 2014
@XhmikosR XhmikosR mentioned this pull request Jun 16, 2014
Closed
@XhmikosR XhmikosR force-pushed the grunt-sass branch 3 times, most recently from e28fdb9 to 4bc157c Compare October 23, 2014 15:24
@XhmikosR
Copy link
Member Author

Almost there :/

@XhmikosR
Copy link
Member Author

XhmikosR commented Feb 3, 2015

Perhaps someone could work around the @at-root lack of support for node-sass? We only use it in one place.

@XhmikosR XhmikosR force-pushed the grunt-sass branch 3 times, most recently from 2a219e7 to f3f026d Compare February 6, 2015 17:17
@XhmikosR XhmikosR changed the title WIP Switch to "grunt-sass" Switch to "grunt-sass" Feb 6, 2015
@XhmikosR
Copy link
Member Author

@cvrebert: this seems to work, should I go ahead with it since it simplifies dependencies and doesn't seem to break anything?

(I know you do not work on Ratchet, I'm just not sure who else to ask for a second opinion)

@cvrebert
Copy link
Contributor

Makes sense to me.

XhmikosR added a commit that referenced this pull request Dec 27, 2015
@XhmikosR
Merge pull request #479 from twbs/grunt-sass
bd50255 
Switch to "grunt-sass"
@XhmikosR XhmikosR merged commit bd50255 into master Dec 27, 2015
@XhmikosR XhmikosR deleted the grunt-sass branch December 27, 2015 00:36
@XhmikosR XhmikosR added this to the 2.1.0 milestone Dec 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@XhmikosR XhmikosR

Labels
grunt
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @cvrebert