-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flake.lock, fix errors, get rid of flake-utils #68
base: master
Are you sure you want to change the base?
Conversation
flake.nix
Outdated
|
||
let | ||
# Matches pkgs.tree-sitter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason we care about tree-sitter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you caught me red-handed copying stuff someone did to get rid of flake-utils from Topiary 🙃 but no, nothing to do with that (and hi 👋 hope you're doing well !)
I'm not sure what to do about the CI error on I'm hesitating between doing what the CI wants, or just ignore this altogether. |
These versions were updated by
I'd recommend updating |
Ok, there was a whole lot of confusion - not least because the |
Issue: #67
Description
This PR started as a simple flake.lock update in order to solve #67. However, it got quickly out of hands. I'm not sure exactly how that's possible, but it seems a lot of flake outputs were actually invalid - I suspect newer versions of Nix now check the flake schema more thoroughly, and I got a ton of error about ill-formed outputs. Typically, non-system dependent outputs such as NixOS configurations and overlays were put in
flake-utils
'forEachSupportedSystem
, which they shouldn't.While trying to get the minimal diff to make it work again, I found that
flake-utils
was more of a burden than a help, typically because we have several outputs that don't fit theoutput.<system>.xxx
convention. So, this PR gets rid offlake-utils
following the technique described in you don't need flake-utils. This required to refactor part of the flakes, because now non-system dependent outputs need to access computed values.Checklist
Checklist before merging: