Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default python kernel #182

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Conversation

Etjean
Copy link
Contributor

@Etjean Etjean commented Jan 14, 2022

This disables the default python kernel in jupyter-lab, jupyter-notebook, and jupyter-nbclassic.

@Etjean Etjean linked an issue Jan 14, 2022 that may be closed by this pull request
@guaraqe
Copy link
Contributor

guaraqe commented Jan 14, 2022

The MacOS tests are not passing, due to the tests of some component of Jupyter not working.

@guaraqe
Copy link
Contributor

guaraqe commented Jan 21, 2022

The setup upterm task has been running for 3 hours already.

@Etjean
Copy link
Contributor Author

Etjean commented Jan 25, 2022

The flake checks currently fail with

error: input 'jupyterWith/ihaskell/hls/pre-commit-hooks/flake-utils' follows a non-existent input 'hls/flake-utils'

According to this thread, it happens when one of the flake input uses the "follows" attribute. Among all chained inputs, only ihaskell used to use this "follows" directive, but not anymore.

When running the flake checks locally, everything runs fine. I suspect cachix uses some cached version of jupyterWith, or iHaskell, that precedes the fix introduced in iHaskell that is linked above (?). I'm not sure how to fix those flakes checks at the moment.

@GTrunSec
Copy link
Collaborator

GTrunSec commented Jan 25, 2022

Just run nix flake lock --update-input ihaskell to fix the flake issue. if you have any issue with the flake please at me as a code reviewer.

@Etjean
Copy link
Contributor Author

Etjean commented Jan 26, 2022

@GTrunSec, Thanks for the suggestion. I gave it a try but that still doesn't pass. Even without updating the lockfile, iHaskell is recent enough, and running nix flake lock --override-input jupyterWith ../.. locally works fine too.

@GTrunSec
Copy link
Collaborator

How about cd example/flake then nix flake update? if it does not work again, I will add the follows for the ihaskell input.

@Etjean Etjean force-pushed the etienne/disable-default-kernel branch from 9c2b2b6 to 9c723f0 Compare January 26, 2022 10:33
@Etjean
Copy link
Contributor Author

Etjean commented Jan 26, 2022

That worked, thanks a lot @GTrunSec.
For some reason, the flake checks failed with nix 2.6, while they passed with nix 2.5. Updating the lockfile in example/flake made them pass with nix 2.6 as well.

@Etjean Etjean requested a review from guaraqe January 26, 2022 10:47
@guaraqe
Copy link
Contributor

guaraqe commented Jan 26, 2022

That's great, thanks!

@guaraqe guaraqe merged commit afea17c into master Jan 26, 2022
@guaraqe guaraqe deleted the etienne/disable-default-kernel branch January 26, 2022 11:27
@Etjean Etjean linked an issue Feb 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to disable ipykernel / configure it? No module named 'matplotlib'
3 participants