Improve hover output for let patterns #1696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the LSP aware of the types of let pattern bindings (when the typechecker knows them, at least).
I'll say that this fixes #1536 even though there's a bigger question about more aggressive type inference, because (1) the original confusion about whether the bound variable refers to the pattern or the thing inside it is fixed (not by this PR), and (2) we're now getting the right type in the fully-typechecked case.