Vendor codespan, and fix character offset issues #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
approved these changes
Jan 30, 2024
| foo = "𐑄𐐮𐑅 𐐰𐑊𐑁𐐰𐐺𐐯𐐻 𐐮𐑆 𐐿𐐭𐑊", bar = 1 | ||
| }.bar | ||
| ### # The "bar" in the first line is at lsp "character" 45--48, | ||
| ### # because lsp measures characters in UTF-16 codepoints 🤦 |
There was a problem hiding this comment.
but is 🤦 an UTF-16 codepoint? Asking important questions.
There was a problem hiding this comment.
it's two of them, apparently...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original motivation here was that I wanted to update
lsp_typesbut was blocked bycodespan_lsp's dependency on an old version.codespan_lspseems to be abandoned (along with the rest of codespan). Since it's only a few utility functions, the easiest thing was to vendor it.While I was doing that, I noticed that we aren't correctly converting byte positions to lsp positions in some of our responses, so I fixed that.