Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the description of identifier syntax in the manual #1839

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

vkleen
Copy link
Contributor

@vkleen vkleen commented Mar 7, 2024

Explicitly mention the validity of dashes and leading underscores.

Fixes #1837

Explicitly mention the validity of dashes and leading underscores.

Fixes #1837
@github-actions github-actions bot temporarily deployed to pull request March 7, 2024 09:32 Inactive
@vkleen vkleen requested a review from yannham March 7, 2024 09:40
Copy link
Member

@yannham yannham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I wonder if we have any good reason to not allow several heading underscores. It's probably an oversight

@vkleen
Copy link
Contributor Author

vkleen commented Mar 7, 2024

I don't think there's any reason, either. We snould probably just tackle that as part of #1534 .

@vkleen vkleen added this pull request to the merge queue Mar 7, 2024
Merged via the queue into master with commit ba20722 Mar 7, 2024
5 checks passed
@vkleen vkleen deleted the manual/describe-identifiers branch March 7, 2024 11:11
@ShalokShalom
Copy link

And once that is tackled, also bring it back into the documentation ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo on the homepage (underscore and dash)
3 participants