Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force enum payloads #1890

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Force enum payloads #1890

merged 2 commits into from
Apr 15, 2024

Conversation

jneem
Copy link
Member

@jneem jneem commented Apr 12, 2024

Currently, enum payloads are being evaluated when the enum is forced, but not deeply evaluated. For example:

nickel> 'Foo { bar = 1 + 2 }
'Foo { bar = 1 + 2, }

Based on the comment in operation.rs, this seems unintentional (because deep_seq does deeply evaluate the payload). This PR changes the behavior to

nickel> 'Foo { bar = 1 + 2 }
'Foo { bar = 3, }

@jneem jneem requested review from yannham and vkleen April 12, 2024 19:27
@github-actions github-actions bot temporarily deployed to pull request April 12, 2024 19:30 Inactive
@jneem jneem added this pull request to the merge queue Apr 15, 2024
Merged via the queue into master with commit 0534393 Apr 15, 2024
5 checks passed
@jneem jneem deleted the force-enum-payloads branch April 15, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants