Tell lsp about variable bindings in match statements #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
reviewed
May 24, 2024
| @@ -162,6 +162,34 @@ impl UsageLookup { | |||
|
|
|||
| TraverseControl::ContinueWithScope(new_env) | |||
| } | |||
| Term::App(f, value) => { | |||
There was a problem hiding this comment.
Should we also do this even when the match isn't applied, like a function definition let foo = match { 'Bar payload => p[.] } to get payload completion on p (and maybe even record completion if we have type information on the argument of foo)?
There was a problem hiding this comment.
Good point, I've added that. I'm having some trouble coming up with a realistic test that uses type information to get completions. The problem is that if typechecking fails then completions just don't work at all right now. (I'll open an issue for this.) This means that something like
fun x => match { y => y.fo } : { foo: Number} -> Number
fails to type-check and therefore doesn't offer completions. I've made it "work" for now by writing
fun x => match { y => y.fo } : { foo: Number, fo: Number} -> Number
yannham
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1925