Fix spawning of too many LSP TestHarnesses
#2098
Merged
+35
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During benchmarking, each criterion run would spawn `TestHarness`, each with its own `lsp` process. They weren't cleaned up between criterion runs, so eventually they would exhaust the system’s process pool. Fixed this by explicitly killing and cleaning up the lsp at the end of a criterion run.
jneem
approved these changes
Nov 20, 2024
|
Bencher Report| Branch | bench-server-cleanup |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| fibonacci 10 | 📈 view plot 🚷 view threshold | 483,030.00 |
| foldl arrays 50 | 📈 view plot 🚷 view threshold | 1,662,400.00 |
| foldl arrays 500 | 📈 view plot 🚷 view threshold | 6,688,400.00 |
| foldr strings 50 | 📈 view plot 🚷 view threshold | 7,054,000.00 |
| foldr strings 500 | 📈 view plot 🚷 view threshold | 61,985,000.00 |
| generate normal 250 | 📈 view plot 🚷 view threshold | 41,626,000.00 |
| generate normal 50 | 📈 view plot 🚷 view threshold | 1,960,300.00 |
| generate normal unchecked 1000 | 📈 view plot 🚷 view threshold | 3,400,500.00 |
| generate normal unchecked 200 | 📈 view plot 🚷 view threshold | 761,080.00 |
| pidigits 100 | 📈 view plot 🚷 view threshold | 3,164,000.00 |
| pipe normal 20 | 📈 view plot 🚷 view threshold | 1,493,600.00 |
| pipe normal 200 | 📈 view plot 🚷 view threshold | 10,008,000.00 |
| product 30 | 📈 view plot 🚷 view threshold | 822,300.00 |
| scalar 10 | 📈 view plot 🚷 view threshold | 1,502,000.00 |
| sum 30 | 📈 view plot 🚷 view threshold | 820,490.00 |
|
Thanks for that @rben01 ! I've had LSP tests randomly hanging in the past but haven't had the drive to investigate. That must be the culprit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During benchmarking, each criterion run would spawn
TestHarness, each with its ownlspprocess. They weren't cleaned up between criterion runs, so eventually they would exhaust the system’s process pool. Fixed this by explicitly killing and cleaning up the lsp at the end of a criterion run.