Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed errant proc.kill() #2103

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Removed errant proc.kill() #2103

merged 3 commits into from
Nov 22, 2024

Commits on Nov 21, 2024

  1. Removed errant proc.kill()

    rben01 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9c65477 View commit details
    Browse the repository at this point in the history
  2. Added finish to benchmark_diagnostics as well

    Thought: do we want to just `impl Drop for TestHarness`? This might make the panicking situation tricky, whereas explicitly calling `harness.finish()`, while possible to forget, makes handling panics just work.
    rben01 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    dc24d4f View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. impl Drop for Server

    Ensures shutdown and cleanup so that we can't forget
    This is important during benchmarking; Criterion creates thousands of servers, and if we don't shut them down and clean them up, we'll exhaust the system's process pool
    rben01 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    9289a22 View commit details
    Browse the repository at this point in the history