-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CONTRIBUTING.md #679
Add CONTRIBUTING.md #679
Conversation
Co-authored-by: Arnaud Spiwack <arnaud.spiwack@tweag.io>
Co-authored-by: Arnaud Spiwack <arnaud.spiwack@tweag.io>
Co-authored-by: Arnaud Spiwack <arnaud.spiwack@tweag.io>
Co-authored-by: Arnaud Spiwack <arnaud.spiwack@tweag.io>
Co-authored-by: Arnaud Spiwack <arnaud.spiwack@tweag.io>
I implemented the suggestions and moved the setup development environment part to a separate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it a quick read but I didn't test all of the command. The whole thing looks very professional :)
Would it be possible to include this on the website? Or at least point to this markdown files.
I haven't had time to try to improve the WASM situation. This guide is still useful, so I propose to merge it as it is and open an issue to remember to try a better solution for building the WASM REPL. @garbas given this is markdown and part of the nickel flake, it wouldn't be hard to either include it as a page or point to it. I wonder where that should go, though? It doesn't concern random prospective users visiting the website, but it may fit somewhere indeed. |
It is fine that this is here. It would be trivial to just copy this two files during the build process of documentation. |
Sorry, I didn't make my question clear enough: I meant where should it appear on the website, as a page or a link. |
I think having a link with some short description would be a good first step for now. |
I really doubt that it has value to add either document to the website. |
No description provided.