-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix haddocks on infix constructors #1118
Fix haddocks on infix constructors #1118
Conversation
53fa9e2
to
1223b9d
Compare
1223b9d
to
7567c15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
While the refactorings in the first three commits don't seem strictly necessary, they are nicely separated and make sense in the context of the additional where
bindings introduced later.
Minor: I usually review changes that involve formatting with difftastic, so I would even be fine if you didn't separate out the formatting commits, but it certainly doesn't hurt; your efforts to increase reviewability are really appreciated!
I always organize my commits anyway, because it's easier for me to reorganize and edit my own work 😃 |
622ee98
to
e8f3d36
Compare
e8f3d36
to
9ad2870
Compare
Resolves #758. Recommend reviewing commit-by-commit