Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Ormolu Live back to Miso #1141

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Oct 23, 2024

Since #964, @TerrorJack added JavaScript FFI and TemplateHaskell support to the GHC WASM backend, so we can now seamlessly switch back to using Miso, simplifying Ormolu Live and superseding previous hacks/workarounds.

Uncompressed .wasm size decreases from 19.13MB to 18.19 MB overall:

  • First, it gets slightly larger because twe now also have the UI logic in WASM, the JS size decreases correspondingly.
  • It also gets larger because ghc-wasm-meta is using -O2 by default since !78.
  • However, it gets significantly smaller because we no longer pre-initialize the fixity database using Wizer. In contrast to the original PR Pre-init Ormolu Live with Wizer #991, I didn't see any performance benefit of evaluating the embedded fixity info, so I removed it.

As it is quite convenient now with Miso + WASM, I also added pre-rendering for a nicer experience on initial page load.

As a side effect of upgrading Bulma to 1.0, we get a dark mode for free 😎

Copy link

github-actions bot commented Oct 23, 2024

@github-actions github-actions bot temporarily deployed to pull request October 23, 2024 08:34 Inactive
@amesgen amesgen force-pushed the amesgen/ormolu-live-wasm-jsffi branch from 9114b7b to 2212beb Compare October 23, 2024 17:27
@github-actions github-actions bot temporarily deployed to pull request October 23, 2024 17:55 Inactive
@amesgen amesgen force-pushed the amesgen/ormolu-live-wasm-jsffi branch 2 times, most recently from 84d59a2 to 45e21a5 Compare October 25, 2024 12:24
@github-actions github-actions bot temporarily deployed to pull request October 25, 2024 12:48 Inactive
@amesgen amesgen force-pushed the amesgen/ormolu-live-wasm-jsffi branch from 45e21a5 to 8e34bad Compare October 26, 2024 13:41
@github-actions github-actions bot temporarily deployed to pull request October 26, 2024 14:02 Inactive
@mrkkrp mrkkrp merged commit 5346f58 into master Oct 28, 2024
8 checks passed
@mrkkrp mrkkrp deleted the amesgen/ormolu-live-wasm-jsffi branch October 28, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants