Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Asterius on Darwin arm64 / Apple M1 #1742

Closed
avdv opened this issue May 16, 2022 · 1 comment
Closed

Support Asterius on Darwin arm64 / Apple M1 #1742

avdv opened this issue May 16, 2022 · 1 comment

Comments

@avdv
Copy link
Member

avdv commented May 16, 2022

Is your feature request related to a problem? Please describe.

When testing rules_haskell I noticed that the nodejs toolchain could not be found. The reason for this is that the default nodejs version (currently 14.17.5 https://github.com/bazelbuild/rules_nodejs/blob/4.4.6/nodejs/repositories.bzl#L11) does not support darwin_arm64 yet, and creation of the corresponding nodejs_darwin_arm64 repository is simply skipped by rules_nodejs.

The first nodejs version that supports running on that platform is the current LTS version 16.x.

Describe the solution you'd like

Upgrade rules_nodejs to version 5.x where 16.x is now the default:

bazel-contrib/rules_nodejs#3107

Additionally, the --experimental-wasm-bigint flag needs to be removed when calling node since it is no longer understood by nodejs >= 16.x.

To that end, we also need to use a more recent Asterius bundle since the --experimental-wasm-bigint flag has been in use by Asterius itself, but was removed as of commit tweag/asterius@9c75ad7.

Describe alternatives you've considered

Instead of upgrading rules_nodejs we could also specify the node_version parameter when calling node_repositories:

load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories")

node_repositories(
    node_version = "16.13.0",
)

Additional context

See https://github.com/bazelbuild/rules_nodejs/wiki/Migrating-to-5.0

Depends on PR #1739

@avdv
Copy link
Member Author

avdv commented Oct 25, 2022

Fixed by #1810

@avdv avdv closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant